makitango / hand-luggage-ninja

https://hand-luggage-ninja.vercel.app
0 stars 0 forks source link

Feature/sort #10

Closed makitango closed 1 year ago

makitango commented 1 year ago

Some additions:

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hand-luggage-ninja ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 17, 2023 0:45am
makitango commented 1 year ago

Nice that you solved this challenging tasks. Unfortunately the logic you came up with is hard to follow and potentially brings performance issues, I left you a comment on that.

I would suggest that you refactor your logic, as it will stand in your way and slow you down on further iterations. You can best fix this now.

I made a prototype for you that isolates the problem and should help you to find a better path:

https://codesandbox.io/s/immutable-waterfall-d8jsfy?file=/src/App.js

As this is a pretty big chunk of your programs logic I expect you to deeply understand code before you take from that prototype. If you use chunks of it please comment on it with explanations, I will check on your understanding for this ;)

This is about your apps architecture, do not worry on spending too much time on this, the better you layed out your app, the easier you will have it on every other feature

I will start looking into it now, thank you for your major effort to demonstrate the issue. ;)