Theme selection - Githubissues

makitango / hand-luggage-ninja

https://hand-luggage-ninja.vercel.app

0 stars 0 forks source link

Theme selection #14

Open makitango opened 1 year ago

makitango commented 1 year ago

Value proposition

As an airplane traveller I want a feature that allows choosing between light or dark mode So that I can have a theme that is more pleasant to the eyes depending on my screen or mood

Description

Acceptance criteria

[ ] option 1: system setting (default)
[ ] option 2: light mode
[ ] option 3: dark mode

Tasks

[ ] create dark mode styling
[ ] create a state for saving the user choice
[ ] create buttons to save and activate the appropriate style

ekat-br commented 1 year ago

Hi @makitango your user story is understandable to me 🙌 Perhaps you could describe more clearly in the acceptance criteria how to activate the dark mode. According to your picture, as a user I first have to go into the settings and can change the appearance there. Your settings can be accessed probably via the navigation. Is that correct?

makitango commented 1 year ago

According to your picture, as a user I first have to go into the settings and can change the appearance there. Your settings can be accessed probably via the navigation. Is that correct?

Actually that was thought to be the result later on. I am currently just implementing "pure" features and they get piled up on my homepage. Once I am done with all of them, I want to create two separate sub-pages, and one for dedicated sites.

I hope that clears up the confusion, but it's very understandable coming from this picture. ;)