makitango / hand-luggage-ninja

https://hand-luggage-ninja.vercel.app
0 stars 0 forks source link

Edit bags #7

Open makitango opened 1 year ago

makitango commented 1 year ago

Value proposition

As an airplane traveller I want a feature that allows editing my bag dimensions So I can correct a mistake from entering, change the dimensions when I get a new bag or change the bag I use for travelling.

Description

Image

Acceptance criteria

Tasks

AliaksandraNovikava commented 1 year ago

Hey Dominic, I would recommend adding more acceptance criteria for this user story🤓

Regarding your tasks: You have a "Delete" button in your wireframes. Maybe you would want to add it to your tasks, or if you plan to implement it in your next user story, I would remove it from your wireframes (and adjust acceptance criteria listet above).

makitango commented 1 year ago

Added the acceptance critera, many thanks! Also removed the delete button which is in fact part of a later US.

matschi3 commented 1 year ago

looks good now 👍🏼 nice detailed description, i like that.

What you could think about for future: use the same Form for entering new data as well as editing the same data giving your form defaultData

makitango commented 1 year ago

use the same Form for entering new data as well as editing the same data giving your form defaultData

That was my initial approach, I hope I can recycle the same component for that. Context-wise, i think there should be no difference; save should either add or update a bag and cancel would just leave the form