search

makiuchi-d / gozxing

Port of ZXing (https://github.com/zxing/zxing) core to pure Go.
Other
565 stars 65 forks source link

datamatrix: first FNC1 as ascii 232 #42

Open mutm opened 3 years ago

mutm commented 3 years ago

To support GS1 Datamatrix format

codecov-commenter commented 3 years ago

Codecov Report

Merging #42 (2ba9850) into master (57132e8) will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #42   +/-   ##
=======================================
  Coverage   97.99%   97.99%           
=======================================
  Files         118      118           
  Lines        8285     8288    +3     
=======================================
+ Hits         8119     8122    +3     
  Misses         97       97           
  Partials       69       69
Impacted Files Coverage Δ
datamatrix/encoder/high_level_encoder.go 97.22% <100.00%> (+0.04%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 57132e8...2ba9850. Read the comment docs.

makiuchi-d commented 3 years ago

Thank you for your contribution.

IMO, it should be indicated by EncodeHintType_GS1_FORMAT rather than a charactor \u00e8. And it need to implement the decoder support.

I want it be implemented on the original ZXing before this repository.