Fix for Laravel 5.5 - Githubissues

maknz / slack-laravel

Laravel integration for the maknz/slack package

BSD 2-Clause "Simplified" License

155 stars 115 forks source link

Fix for Laravel 5.5 #23

Open RohanSakhale opened 7 years ago

marcinj1 commented 6 years ago

Please update. I'm using your package and i'm getting error

RohanSakhale commented 6 years ago

@skmetaly also listed Laravel 5.5, auto package discovery in composer.json

skecskes commented 6 years ago

I just made a fork and fixed it there: if anybody is interested: https://github.com/phpify/slack-laravel or just composer require phpify/slack-laravel

jeremykenedy commented 6 years ago

The package is no longer being maintained... here is my fork of it..

composer require jeremykenedy/slack-laravel

https://github.com/jeremykenedy/slack-laravel

qmcree commented 6 years ago

This PR worked well for me and fixed the Laravel 5.5 incompatibility issues. It should be accepted. :) Thanks, @RohanSakhale!

cedricve commented 6 years ago

Please merge.

RohanSakhale commented 6 years ago

@skmetaly could you please merge this PR

dannytrue commented 6 years ago

just implemented the same fix on my local and then found the same solution in PR.

maurocasas commented 6 years ago

@maknz WTF ARE YOU WAITING FOR TO MERGE THIS.

qmcree commented 6 years ago

@maurocasas You don’t need to wait on him. Just update the dependency in your package manager to be constrained to this specific commit hash.

maknz commented 5 years ago

If you took 30 seconds to glance at the README, you'd see this package is no longer being maintained as of early 2017. Use one of the (100+) forks that implements the features you want, or make your own.

Screaming at me to "WTF ARE YOU DOING MERGE THIS" only serves to discourage me from ever contributing open source code again.