search

maknz / slack

A simple PHP package for sending messages to Slack, with a focus on ease of use and elegant syntax.
BSD 2-Clause "Simplified" License
1.17k stars 204 forks source link

Support for Symfony bundle #37

Closed soullivaneuh closed 8 years ago

soullivaneuh commented 8 years ago

I see you have Laravel native support.

Would you accept a PR for Symfony bundle support?

maknz commented 8 years ago

I'm not familiar with Symfony bundles so I'm a bit apprehensive about adding support for it.

Maybe you could write your own package which requires maknz/slack, but provides whatever interface is required for Symfony bundles?

soullivaneuh commented 8 years ago

I'm not familiar with Symfony bundles so I'm a bit apprehensive about adding support for it.

This why I'm proposing my help. ;-)

Maybe you could write your own package which requires maknz/slack, but provides whatever interface is required for Symfony bundles?

Yes I could, but it's easier for users to propose direct implementation on your project.

But yes, I can do that. Maybe you can add a link to your repo when mine will be finished?

maknz commented 8 years ago

It'll be my responsibility after it's merged, not something I'm willing to support. Besides, it makes more sense to have further providers added as packages which provide the required functionality for Symfony rather than in the core.

Happy to mention it in the README.

soullivaneuh commented 8 years ago

Ok @maknz I'll start it this week, stay tuned! :+1:

soullivaneuh commented 8 years ago

WIP here: https://github.com/nexylan/NexySlackBundle