Drop PHP 5.4, throw an exception if JSON encoding fails

maknz / slack

A simple PHP package for sending messages to Slack, with a focus on ease of use and elegant syntax.

BSD 2-Clause "Simplified" License

1.17k stars 204 forks source link

Drop PHP 5.4, throw an exception if JSON encoding fails #48

Closed maknz closed 8 years ago

maknz commented 8 years ago

Fixes #27 and replaces #28.

If JSON encoding fails (for example, by bad character encoding), a RuntimeException will be thrown with a descriptive message of the problem.

maknz commented 8 years ago

Okay, seems 5.4 has some annoying inconsistencies with character encoding, that aren't present in 5.5 and above (as verified by Travis). So I'm inclined to drop 5.4 support. That means we do need to bump the major version to 2.0 when we next release master, but considering we want to introduce support for multiple teams, that'd likely be required anyway.