Create React App Integration

makoto / blockparty

NO BLOCK NO PARTY

MIT License

164 stars 41 forks source link

Create React App Integration #31

Closed jefflau closed 7 years ago

jefflau commented 7 years ago

Adds hot module reloading.
Jest for unit testing.
Production build with minification
Restructures JS
Adds public folder with index.html for CRA webpack configuration
Uses requires to get images

Can use npm start or truffle serve to start the server

jefflau commented 7 years ago

Hey Makoto,

Was away this weekend. So i used create react app which has a production webpack build, to do that you need to run npm run build and it'll build the frontend app into a build folder. we'll probably need to add the contracts in somehow, but i haven't tested out building a production version and deploying.

truffle serve will just run npm start which is the development version

makoto commented 7 years ago

Is the only difference between development and productions minification? If so I can approve this. We can have more env specific configuration in different PR

jefflau commented 7 years ago

As far as I am aware yes. Yes I think that would be best.

Sent from my iPhone

On Oct 9, 2016, at 9:59 PM, Makoto Inoue notifications@github.com<mailto:notifications@github.com> wrote:

Is the only difference between development and productions are minification? If so I can approve this. We can have more env specific configuration in different PR

You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/makoto/blockparty/pull/31#issuecomment-252487926, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABKiFR_5RvY7ySUZBgtzdjiBa2pZ6M-8ks5qyPMhgaJpZM4KK6zz.

makoto commented 7 years ago

Approved. Please merge.