search

makrohn / Universal-LPC-spritesheet

An attempt to merge most character assets generated by the Liberated Pixel Cup into a single .xcf, where they can be mixed and matched.
333 stars 168 forks source link

hair colour renames. read before merging #39

Closed caeles0 closed 11 years ago

caeles0 commented 11 years ago

Previously, hair colour file names were inconsistent across hair styles. For example, ponytail2/redhead.png was the same colour as swoop/dark-blonde.png, and ponytail2/raven.png was the same as swoop/raven2.png, not swoop/raven.png

This pull request's commit fixes all inconsistencies. The possible downside is that the underlying renames break existing setups.

So please be aware that the present pull request is more intrusive than previous ones.

makrohn commented 11 years ago

In Guarav0's JS-based website for character generation, he references file names of all these hair styles and colors. If we put symlinks in for the old filenames to the new ones, would that work? I'm not familiar enough with JavaScript to know how it'd handle links.

caeles0 commented 11 years ago

On Sat, Mar 16, 2013 at 11:13:48AM -0700, Matthew Krohn wrote:

In Guarav0's JS-based website for character generation, he references file names of all these hair styles and colors. If we put symlinks in for the old filenames to the new ones, would that work? I'm not familiar enough with JavaScript to know how it'd handle links.

I don't know JS either but I would expect that unless it implements special handling of symlinks it should work. And I see no reason for JS to do implement special handling. But my guess is as good as anyone else's.

More background to the commit: Joe White added his hair styles with colour ramps that had the same names as previous ones but were in fact different. Prefering his ramps over the others, I ported (some of) them to all other (for the time being: female) hair styles, suffixing a "2" to their names. The present commit adds that "2" to the ramps in Joe White's styles as well.

Something worth to keep in mind is that eventually, someone might want to add the non-Joe-White ramps to Joe White's hair styles as well. Any symlink we add now would then be replaced by a new png.

One last note about renames: They are inevitable in general, because file names carry substrings such as "wc-only" or "no-th" which can (and should!) become out-of-date.

Gaurav0 commented 11 years ago

Hi all.

Symlinks will not help, the web server I'm hosting the character generator on is configured not to follow them. (You can research all the reasons why following symlinks is insecure on a shared host.)

The best thing to do is when you rename a file, edit the index.html file in my char generator to change the appropriate file name. I have all the file paths referenced within index.html under the custom attributes data-file, data-file_male, data-file_female etc. Editing this HTML file requires no knowledge of javascript. Then send me a pull request.

Gaurav

P.S. Feel free to ask me questions directly in the future.