maks-sh / scikit-uplift

:exclamation: uplift modeling in scikit-learn style in python :snake:
https://www.uplift-modeling.com
MIT License
725 stars 96 forks source link

Bug when importing all metrics #119

Closed ezhdi closed 3 years ago

ezhdi commented 3 years ago

🐛 Bug

To Reproduce

from sklift.metrics import *

TypeError                                 Traceback (most recent call last)
<ipython-input-2-89f0d9d4fc6d> in <module>
----> 1 from sklift.metrics import *

~/anaconda3/lib/python3.7/importlib/_bootstrap.py in _handle_fromlist(module, fromlist, import_, recursive)

~/anaconda3/lib/python3.7/importlib/_bootstrap.py in _handle_fromlist(module, fromlist, import_, recursive)

TypeError: Item in sklift.metrics.__all__ must be str, not function

Снимок экрана от 2021-07-18 14-49-27

Environment

maks-sh commented 3 years ago

@ezhdi Thanks for reporting the bug.

Please make a submission on the ods.ai with a link to this issue.

I think you can easily fix this bug 👍

ezhdi commented 3 years ago

Take it