Unwanted treatment variable in plot_uplift_preds( )

maks-sh / scikit-uplift

:exclamation: uplift modeling in scikit-learn style in python :snake:

https://www.uplift-modeling.com

MIT License

725 stars 96 forks source link

Closed anwarbabukm closed 3 years ago

anwarbabukm commented 3 years ago

Error : 'treatment is not defined'

Causing the error 'treatment is not defined' while running the plot_uplift_preds( )

check_is_binary(treatment) seems unnecessary for this particular visualization function.

maks-sh commented 3 years ago

Hi!

Thanks for the issue.

It is really a bug 🐛 .

bwbelljr commented 3 years ago

Created a pull request to remove the unnecessary line. This is also causing a problem for a tutorial I am working through.

maks-sh commented 3 years ago

Thank you so much!

Fixed in version 0.3.2.