Fix attribute call in fetch_x5 related to issue #89 - Githubissues

maks-sh / scikit-uplift

:exclamation: uplift modeling in scikit-learn style in python :snake:

https://www.uplift-modeling.com

MIT License

725 stars 96 forks source link

Fix attribute call in fetch_x5 related to issue #89 #90

Closed Muhamob closed 3 years ago

Muhamob commented 3 years ago

name: "Pull request" about: Make changes in scikit-uplift

📑 Description of the Change

Fix attribute getter in function fetch_x5 from list(clients.column) to list(clients.columns) as the former call raises

AttributeError: 'DataFrame' object has no attribute 'column'

Verification Process

Run method

dataset.fetch_x5()

Release Notes

Fix typo in fetch_x5 function

Additional info

The most possible reason for this bug to occur is the missing test cases for x5 dataset

maks-sh commented 3 years ago

Thanks for contributing! 👍