search

maks / MGit

A Git client for Android.
https://manichord.com/projects/mgit.html
GNU General Public License v3.0
1.25k stars 167 forks source link

Clean up images #211

Open marukami opened 7 years ago

marukami commented 7 years ago

We are missing densities for a lot of assets. We could also make a lot of the icons vectorDrawable. Using vectorDrawable would mean adding AppCompat base activities.

Where vectorDrawable we just need to add the missing densities.

Android Studio has a heap of vector assets bundled with it. There is also the Material Design icon package

maks commented 7 years ago

@marukami :+1: I've been swamped trying to get bug fixes & new functionality done in limited time on the project recently, so sadly UI issues have fallen by the wayside.

Pretty much all the standard icons can immediately switch to vectors and the rest should likely be fairly easy to replace and even if not should be as I don't know their origin anyways.

@marukami if you'd like to have a go at this let me know and I'll mark this as assigned to you :smile:

Evidlo commented 7 years ago

Heh, its also pretty obvious the logo is ripped from git-scm. You can even see a slight red outline around it because of the gradient used on the original image.

Still, nice app though.

maks commented 7 years ago

@Evidlo not sure about the use of the word "ripped". The logo is based on the Git logo and per its license:

Git Logo by Jason Long is licensed under the Creative Commons Attribution 3.0 Unported License. This license lets others distribute, remix, tweak, and build upon your work, even commercially, as long as they credit you for the original creation.

But you raise a good point that there is no acknowledgement of this in the app at the moment, so I've raised a new issue to address this: #230