search

maks / MGit

A Git client for Android.
https://manichord.com/projects/mgit.html
GNU General Public License v3.0
1.21k stars 166 forks source link

Localization of JGit strings #403

Open kb-1000 opened 6 years ago

kb-1000 commented 6 years ago

JGit uses ResourceBundle. This means we have two choices to do this:

  1. Creating .properties files
  2. Using strings.xml files and creating a custom ResourceBundle implementation
maks commented 6 years ago

I'd prefer in most cases to not directly show jgit messages to the user, but rather catch jgit exceptions and then display errors from MGits string resources. @kaeptblaubaer1000 can you think of any cases where that approach wouldn't work?

kb-1000 commented 6 years ago

@maks "Receiving objects", "Resolving deltas" and "Updating references", but there are many others.

maks commented 6 years ago

Ah ok, so these are status messages. Hmm, ok in that case it does make sense to provide localised strings to show users, I'm open to either option, or even better a sample implementation PR 🙂