Support images in file viewer

maks / MGit

A Git client for Android.

https://manichord.com/projects/mgit.html

GNU General Public License v3.0

1.22k stars 166 forks source link

Support images in file viewer #528

Open maks opened 4 years ago

maks commented 4 years ago

Add support for displaying in the file viewer the most common image types (png, gif) found in source code repos.

omkar-tenkale commented 3 years ago

It's just 3 lines of code with this library

https://github.com/stfalcon-studio/StfalconImageViewer

I can create a pull request if you want

kb-1000 commented 3 years ago

Looks like it requires AndroidX. That means it's not just 3 lines, you would need to do the full AndroidX migration first.

maks commented 3 years ago

@omkar-tenkale Thanks for the offer, I'm always happy for people to contribute to the project, especially PRs. If you do, do please be aware that I would like to Androidx in the future but that's too big a change for me to look at doing right now