search

maksim-paskal / aks-node-termination-handler

Gracefully handle Azure Virtual Machines shutdown within Kubernetes
Apache License 2.0
34 stars 6 forks source link

refactor pkg folder #61

Closed maksim-paskal closed 8 months ago

maksim-paskal commented 8 months ago

refactor pkg source folder, need more test coverage. Also add new flags for making timeouts in http requests

  -request.timeout duration
        request timeout (default 1s)
  -webhook.timeout duration
        request timeout (default 5s)
codecov-commenter commented 8 months ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (a7315a0) 48.46% compared to head (f694fca) 98.30%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #61 +/- ## =========================================== + Coverage 48.46% 98.30% +49.83% =========================================== Files 4 6 +2 Lines 163 177 +14 =========================================== + Hits 79 174 +95 + Misses 76 2 -74 + Partials 8 1 -7 ``` | [Files](https://app.codecov.io/gh/maksim-paskal/aks-node-termination-handler/pull/61?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Maksim+Paskal) | Coverage Δ | | |---|---|---| | [pkg/config/config.go](https://app.codecov.io/gh/maksim-paskal/aks-node-termination-handler/pull/61?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Maksim+Paskal#diff-cGtnL2NvbmZpZy9jb25maWcuZ28=) | `93.87% <ø> (+26.53%)` | :arrow_up: | | [pkg/logger/logger.go](https://app.codecov.io/gh/maksim-paskal/aks-node-termination-handler/pull/61?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Maksim+Paskal#diff-cGtnL2xvZ2dlci9sb2dnZXIuZ28=) | `100.00% <100.00%> (ø)` | | | [pkg/metrics/metrics.go](https://app.codecov.io/gh/maksim-paskal/aks-node-termination-handler/pull/61?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Maksim+Paskal#diff-cGtnL21ldHJpY3MvbWV0cmljcy5nbw==) | `100.00% <100.00%> (ø)` | | | [pkg/webhook/webhook.go](https://app.codecov.io/gh/maksim-paskal/aks-node-termination-handler/pull/61?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Maksim+Paskal#diff-cGtnL3dlYmhvb2svd2ViaG9vay5nbw==) | `100.00% <100.00%> (ø)` | | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/maksim-paskal/aks-node-termination-handler/pull/61/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Maksim+Paskal)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.