maksim789456 / DynamicSurroundingsFabric

Fabric Version of Dynamic Surroundings mod for Minecraft
MIT License
19 stars 7 forks source link

Addressing Unexpected Behavior at Runtime #31

Closed AntonBoch1244 closed 1 year ago

AntonBoch1244 commented 1 year ago

Issue: #29

potential-bug-fix

In class SoundFXProcessor:

Line: 146 <- Pointer of Issue At runtime have unexpected behavior for solving var id as byte, but not as int for sources. getId() in ISourceContext class has return value of int.

For some reason in certain environments we have interesting behavior for solving this variable as byte, but expecting int.

Actual solution change type from var to int at line 139. Cause ISourceContext.getId() returns int.