maksimhorowitz / nflscrapR

R Package for Scraping and Aggregating NFL Data
528 stars 138 forks source link

nearly 8% of data (aggregated over all seasons) doesn't have 'Extra Point Result' or 'Two Point Conversion Result' after Touch Down. #98

Open pareenkalia opened 5 years ago

pareenkalia commented 5 years ago

Hi, I found some issues with the 'score difference' field. The following is a list of 'game_id's that have a score_difference > 0 at the end of the 4th quarter (when time = 0) and still go into overtime. Upon looking at each of these games individually, it looks like they are, in fact, overtime games but the score difference is wrong - they are either missing an extra point or a whole touch down in the score, making it seem like the games didn't tie at the end of the 4th quarter.

[2009100401, 2009101802, 2009120608, 2009122707, 2010110705, 2010112108, 2010120510, 2012092306, 2012092303, 2012111803, 2012112200, 2012120202, 2013091505, 2013092903, 2013103100, 2013110305, 2013111701, 2013112411, 2013121509, 2013122210, 2014100505, 2014120705, 2015091301, 2015101102, 2015101805, 2015110810, 2015120600, 2015122702, 2016092505, 2016102309]

Any way to fix this?

sventura commented 5 years ago

Issues #60 and #23 discuss this. The error is not in the package/code, but in the data available on the league's API. Suggestions for how to address this are welcome.