search

makson96 / Dynamics

Dynamics PyMOL Plugin
GNU General Public License v3.0
40 stars 16 forks source link

better PyMOL 2.x support #95

Closed speleo3 closed 6 years ago

speleo3 commented 6 years ago

Don't call Tk().mainloop(), use Toplevel(self.root) instead. This prevents locking up the PyMOL interface while the plugin is open.

Don't call configure() in bar_update thread.

Tested on macOS 10.12 with PyMOL 2.1 and MacPyMOLX11Hybrid 1.8.6

Addresses #92

makson96 commented 6 years ago

Hi, Thank you for your code donation. At the moment I am focusing on last issue with GROMACS 2018 and implicit solvent. When it is fixed I will release Dynamics Plugin 2.2. When it is done I will focus on integrating your patches into master. They look good and TravisCI works fine with them, but I will perform some manual tests anyway. Once again thank you.

speleo3 commented 6 years ago

Hi @makson96 - sounds good! Let me know if you have any questions regarding my patch.