mal-lang / coreLang

A probabilistic attack simulation language for the (abstract) IT domain
https://mal-lang.org/coreLang/
Other
10 stars 12 forks source link

Naming issues #3

Open maxwalls opened 4 years ago

maxwalls commented 4 years ago

Things that might need to be renamed:

pdeliasson commented 4 years ago

Added a request to set conventions for "attemptX". Needs to be reviewed.

skatsikeas commented 4 years ago

The above issue (mentioned by Per) was fixed in https://github.com/mal-lang/coreLang/commit/a23b12a65a56e1be1c683e6eb77d65e1f8e67231. We concluded that "Attempt" should be used either when effort is associated with an attack's end result or in order to signify the need of additional attack steps to reach the goal.

andrewbwm commented 3 years ago

I have two issues that may belong on that list.

First, ManuallyModeledVulnerability has a defence called userInteracts. Being a defence it prevents an attack from occurring, therefore it should be renamed to userDoesNotInteract.

Second, neither ManualLowImpactVulnerability nor 'ManualHighImpactVulnerability' trigger any attack steps on either System or Object assets. Maybe they should be renamed to something along the lines of ManualLowImpactSoftwareVulnerability or ManualLowImpactApplicationVulnerability for added clarity.