search

mal-lang / mal-toolbox

Apache License 2.0
4 stars 2 forks source link

Don't assume about the virtual env dir name #66

Closed nkakouros closed 1 month ago

nkakouros commented 3 months ago

Actually, mypy ignores files/dirs starting with .. So why not install your venv under .venv? And then only the pyproject.toml file will need to be updated.

nkakouros commented 3 months ago

Actually, I will make some further edits.

andrewbwm commented 1 month ago

Actually, I will make some further edits.

@nkakouros what is going on with this pull request? Is it still relevant? Is still being worked on? Did the intervening changes make it obsolete or require an update?

nkakouros commented 1 month ago

I don't remember. There was a better way to handle some things, but I am not sure anymore. Given that the checks pass and in particular that the mypy check finds and checks all files, I would merge this to avoid virtualenv folders from being picked up by mypy.

andrewbwm commented 1 month ago

Was squashed into 2df9b74a77a60206ae631ca368080bfb96f5f86b.