Refactor to use additional classes

malandrina / word_reference

A Ruby wrapper for the WordReference API

MIT License

5 stars 1 forks source link

Refactor to use additional classes #5

Closed malandrina closed 10 years ago

malandrina commented 10 years ago

Refactor to use additional classes, WordReferenceApi and ResponseParser, to handle querying API and parsing response.
Upgrade rspec and add rspec-mocks
Remove whitespace and newlines

sandbochs commented 10 years ago

Looks awesome. The response parser class is a great addition.

malandrina commented 10 years ago

Thanks @sandbochs! I added a commit that actually fixes one of the bugs: https://github.com/malandrina/word_reference/commit/366ec6e47ae59efa26a25a5146ac671dca0f6756. Can you take a look when you have a moment?

malandrina commented 10 years ago

@sandbochs yes I agree -- when I was reviewing the Dictionary, Query, and Translation classes I had a hard time figuring out exactly what they did! Perhaps some additional refactoring on the private interfaces will help.

For now, I'll go ahead and merge this in.