search

malaporte / nashorn-commonjs-modules

CommonJS modules support for Nashorn
MIT License
108 stars 31 forks source link

Use real JS object whenever we need an instance of Bindings #17

Closed malaporte closed 7 years ago

malaporte commented 7 years ago

As pointed out by @kipz in this PR Nashorn doesn't support defining properties on instances of SimpleBindings. I took the liberty to extend his proposed fix in order to use JS objects pretty much everywhere those were used. This should address issue #15.

kipz commented 7 years ago

LGTM and much more comprehensive than #16