Try using index.js if 'main' in package.json is a directory

malaporte / nashorn-commonjs-modules

CommonJS modules support for Nashorn

MIT License

108 stars 31 forks source link

Try using index.js if 'main' in package.json is a directory #21

Closed kipz closed 7 years ago

kipz commented 7 years ago

This is happening more and more in modules in the wild, and Node seems to deal with this totally fine.

kipz commented 7 years ago

Thanks for the quick turn around. I've moved the test and converted it to using mocks as requested.

I really appreciate you taking the time to consider our contributions!

kipz commented 7 years ago

Thanks for merging.

There are a few useful changes in master right now, so I was wondering if you were considering a release any time soon?

malaporte commented 7 years ago

Well I tried to do one last weekend, but for some reason my GnuPG installation was all borked up. I just found the issue: it was missing an env variable to point it to my TTY, which it uses to ask me for my passphrase. Funny thing is that it never asked me for it before, on this very laptop, but hey.

Release should be available shortly.

kipz commented 7 years ago

Much appreciated. I'm grabbing it now!