search

malaporte / nashorn-commonjs-modules

CommonJS modules support for Nashorn
MIT License
108 stars 31 forks source link

Attempt to fix unit test on Windows #29

Closed malaporte closed 6 years ago

malaporte commented 6 years ago

Fixes #28

arisone commented 6 years ago

@malaporte the fix is incomplete. The methods which fail are the following but the fix is only for the first one:

  1. rootFolderHasTheExpectedProperties(com.coveo.nashorn_modules.FilesystemFolderTest)
  2. getFolderReturnsAnObjectWithTheExpectedProperties(com.coveo.nashorn_modules.FilesystemFolderTest)

I'd like to suggest a more extended fix which involves both the FilesystemFolderand the FilesystemFolderTest as explained in this comment to #28 I've proposed a change both on class and on test which should fix the issue.

malaporte commented 6 years ago

Obsoleted by #31