class fields/methods should be protected, not private

malaporte / nashorn-commonjs-modules

CommonJS modules support for Nashorn

MIT License

108 stars 31 forks source link

class fields/methods should be protected, not private #35

Closed abonstu closed 6 years ago

abonstu commented 6 years ago

Pretty much all class fields and methods are private which makes it impossible to extend.

Can these be changed to protected instead?

malaporte commented 6 years ago

Well, no. Only methods that are explicitly designed to be overridden should be protected. The others are private implementation details and should remain so.

If you can answer my question in the other issue you created it'd help figure out if the behavior change you're looking for is really correct or not...