Closed Danpfeffer closed 6 years ago
Thanks @danpfeffer! One test failed which doesn't make much sense given minor tweaks to the readme. I've restarted that build in case it was just a server thing.
Otherwise I or someone will have to have a look.
Merging #27 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #27 +/- ##
=======================================
Coverage 90.57% 90.57%
=======================================
Files 22 22
Lines 1560 1560
=======================================
Hits 1413 1413
Misses 147 147
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 931fc69...ab52062. Read the comment docs.
I guess we should get rid of the "## Warning: package 'malariaAtlas' was built under R version 3.4.4" stuff at the top of the readme. Just a
```{r, echo = FALSE, message = FALSE, results = "hide"}
change to
```{r, echo = FALSE, message = FALSE, results = "hide", warning = FALSE}
should do it I think. I'll do it at some point if you don't fancy faffing.
I guess we should get rid of the "## Warning: package 'malariaAtlas' was built under R version 3.4.4" stuff at the top of the readme. Just a
```{r, echo = FALSE, message = FALSE, results = "hide"}
change to
```{r, echo = FALSE, message = FALSE, results = "hide", warning = FALSE}
should do it I think. I'll do it at some point if you don't fancy faffing.
Ah man, that would be my bad! Thanks for picking that up, will fix and merge myself.
Great thanks!
np! shall I leave the tweaks branch around for now or delete?
You can delete I think. All changes are merged.
On Thu, 15 Nov 2018, 23:59 Danpfeffer <notifications@github.com wrote:
np! shall I leave the tweaks branch around for now or delete?
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/malaria-atlas-project/malariaAtlas/pull/27#issuecomment-439234090, or mute the thread https://github.com/notifications/unsubscribe-auth/ADavNKnQ_rEKVLJavwSxHhzOS3IzBTzpks5uvf_TgaJpZM4YfRgn .
@shk313 @timcdlucas