search

malaria-atlas-project / malariaAtlas

An R interface to open-access malaria data, hosted by the Malaria Atlas Project.
https://malariajournal.biomedcentral.com/articles/10.1186/s12936-018-2500-5
Other
43 stars 21 forks source link

Fix factors tests properly. #51

Open timcdlucas opened 4 years ago

timcdlucas commented 4 years ago

https://developer.r-project.org/blosxom.cgi/R-devel/NEWS/2020/02/28#n2020-02-28

Check now passes stringsAsFactors = TRUE. So all the downloaded data gets characters instead of factors that made some tests fail.

So far I've just hacked things. https://github.com/malaria-atlas-project/malariaAtlas/pull/50

Either we want to wait until stable and dev agree, and then write sensible tests. Or change getPR and other functions to be explicit.