search

malaria-atlas-project / malariaAtlas

An R interface to open-access malaria data, hosted by the Malaria Atlas Project.
https://malariajournal.biomedcentral.com/articles/10.1186/s12936-018-2500-5
Other
43 stars 21 forks source link

DHS Fill fix #56

Closed OJWatson closed 3 years ago

OJWatson commented 3 years ago

This is not the error causing #55 , which I think is due to an outdated rdhs version.

However, when checking I noticed a big that will cause issues when all surveys are found with a login as the -which(...) subsetting would be length of 0 if all surveys are available.

codecov-commenter commented 3 years ago

Codecov Report

Merging #56 (3110b5e) into master (1f9e290) will decrease coverage by 0.16%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #56      +/-   ##
==========================================
- Coverage   86.17%   86.01%   -0.17%     
==========================================
  Files          23       23              
  Lines        1570     1573       +3     
==========================================
  Hits         1353     1353              
- Misses        217      220       +3
Impacted Files Coverage Δ
R/fillDHScoordinates.R 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1f9e290...3110b5e. Read the comment docs.

mauricio-tki commented 3 years ago

Hi @OJWatson. Thanks for fixing this, and apologies for the very late reply. As Tim mentioned in #55 I (and also @joemap and @cavargasru) am now handling maintenance of this repo. I'll be looking at the backlog this month and try to submit a new build to CRAN soon.

Your fix looks good to me. I've just pushed a commit to fix some indentation, and it'll be good to merge.