malariagen / ag1000g-phase1-vgsc-report

MIT License
1 stars 7 forks source link

discussion section on phenotype prediction #148

Closed cclarkson closed 6 years ago

cclarkson commented 6 years ago

Hi @alimanfoo,

I've introduced the concept of prediction into the discussion, but I'm not too sure what to include in the second paragraph, describing table 2. We have already gone into a lot of detail about the relationship between variants at the start of the Results and I felt I was repeating myself.

Any ideas how to make this section more interesting?

N.B. I have also added the correct Xenopus N1570Y references so if we don't merge this branch, these need adding in somewhere else.

alimanfoo commented 6 years ago

Thanks, I'll take a look asap.

On Friday, January 19, 2018, Chris Clarkson notifications@github.com wrote:

Hi @alimanfoo https://github.com/alimanfoo,

I've introduced the concept of prediction into the discussion, but I'm not too sure what to include in the second paragraph, describing table 2. We have already gone into a lot of detail about the relationship between variants at the start of the Results and I felt I was repeating myself.

Any ideas how to make this section more interesting?

You can view, comment on, or merge this pull request online at:

https://github.com/malariagen/agam-vgsc-report/pull/148 Commit Summary

  • discussion section on predication

File Changes

Patch Links:

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/malariagen/agam-vgsc-report/pull/148, or mute the thread https://github.com/notifications/unsubscribe-auth/AAq8Qn0cW8eEdRf2UWtpAAprK12X8P5Uks5tMLykgaJpZM4Rkr4J .

-- Alistair Miles Head of Epidemiological Informatics Centre for Genomics and Global Health http://cggh.org Big Data Institute Building Old Road Campus Roosevelt Drive Oxford OX3 7LF United Kingdom Phone: +44 (0)1865 743596 Email: alimanfoo@googlemail.com Web: http://a http://purl.org/net/alimanlimanfoo.github.io/ Twitter: https://twitter.com/alimanfoo

cclarkson commented 6 years ago

Removing table 2, adding 'domain' column, with updated Dong/Wang naming to table 1.