malariagen / ag1000g-phase1-vgsc-report

MIT License
1 stars 7 forks source link

Map artwork 20170912 #94

Closed alimanfoo closed 7 years ago

alimanfoo commented 7 years ago

This PR has some work on the outbreaks map. Addresses #75.

alimanfoo commented 7 years ago

Hi Chris, I've done some work on this, will need a bit of discussion I'm sure, main change is revisions to the map:

map

Some points for discussion:

Any thoughts on these or any other points?

alimanfoo commented 7 years ago

Oh, and I did stick with splitting Cameroon mainly for the aesthetics, although the notebook generates a base image for Cameroon as a whole also. Again happy to discuss.

cclarkson commented 7 years ago

Looks cool, although I am not too sure about the dashed line around the Western populations. Could this be circular?

Ditching the question marks is sensible.

If we split Cameroon here, would we need to split it elsewhere?

Figure need labels for Norris/Clarkson and the three Cameroon sites.

alimanfoo commented 7 years ago

Hi Chris, Dominic has asked for an updated ms to look at tomorrow so I'm going to merge this now, but I'll raise a new issue for further work on the map so please feel free to take a crack at it.