Generate feature accessibility tables q86, accessibility plots, divergence plots

malariagen / ag1000g-phase3-data-paper

Other

1 stars 2 forks source link

Closed hardingnj closed 3 years ago

review-notebook-app[bot] commented 3 years ago

Check out this pull request on

Review Jupyter notebook visual diffs & provide feedback on notebooks.

Powered by ReviewNB

hardingnj commented 3 years ago

Accessibility figure to follow to this PR

hardingnj commented 3 years ago

ready for review

cclarkson commented 3 years ago

Hi @hardingnj,

This looks great, can be merged, just a couple of comments:

a single table, even at this stage, would make the accessibility easy to eyeball.
when we discussed this a while ago, you mentioned making the 'whole genome scan plot' more compact by sitting across just two rows. Is this still something you want to add here?

hardingnj commented 3 years ago

working on adding text around genome accessibility and including all exome in features.

hardingnj commented 3 years ago

Merging for now- need to reorg notebook names and tables for clarity etc