q41 add text re: wild sample and crosses.

malariagen / ag1000g-phase3-data-paper

Other

1 stars 2 forks source link

q41 add text re: wild sample and crosses. #36

Closed hardingnj closed 3 years ago

hardingnj commented 3 years ago

This supersedes #33

Hi Chris, took the liberty of

renaming the notebook for consistency
removing the addition of the cross metadata. Then I squashed a few commits.

review-notebook-app[bot] commented 3 years ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

hardingnj commented 3 years ago

Hi @cclarkson , is this ready for review? or is there more you'd like to do here

cclarkson commented 3 years ago

Hi @hardingnj, I have updated the results and methods with the correct crosses info. There's just one section I'd like to add to the methods before this is ready for review/merge, which is @jonbrenas's methods for picking the new cross fathers.

@jonbrenas, it is probably easiest if you just send me a sentence/few sentences and I will incorporate them to this PR.

cclarkson commented 3 years ago

@hardingnj @leehart - this is now finally ready for review.