malariagen / datalab

Repo for files and issues related to cloud deployment of JupyterHub.
MIT License
0 stars 1 forks source link

Customise welcome page #17

Open alimanfoo opened 6 years ago

alimanfoo commented 6 years ago

It would be nice to customise the welcome page a bit, to say what the site is. Happy to do this if someone can tell me which file(s) I'd need to edit.

slejdops commented 6 years ago

I'm working on it. I've extracted the templates (Jinja2) from the hub container and put them in github https://github.com/slejdops/jupyterhub-templates

So far I have only changed the jupyter logo to ours.

slejdops commented 6 years ago

I have customized the hub home page. https://cloud.malariagen.net/hub/home

alimanfoo commented 6 years ago

@slejdops nice! Could you point me to the source code for the templates? If I wanted to add some text is it possible for me to do that via a PR?

slejdops commented 6 years ago

@alimanfoo I'll upload them to github. At the moment I can't create new repos under https://github.com/malariagen For now I've kept the template files here https://gitlab.com/slejdops/jhub-template.git

alimanfoo commented 6 years ago

@slejdops I keep meaning to give you admin access the malariagen org, will do that. But in this case can't the templates live within this repo?

alimanfoo commented 6 years ago

...would be nice to keep things related to jupyterhub together (except for the helm charts of course where there is a good reason to use a separate repo).

slejdops commented 6 years ago

I wanted to keep the jinja templates in a separate repo so the URL is shorter. The template github repo gets mounted on the pod

`extraVolumes:

and shorter URLs make the config files more readable

alimanfoo commented 6 years ago

Seems to me you could just bring across the content from your jhub-template repo directly into this repo. In which case you would just be replacing " https://gitlab.com/slejdops/jhub-template.git" with " https://github.com/malariagen/jupyterhub.git".

On Friday, 29 June 2018, slejdops notifications@github.com wrote:

I wanted to keep the jinja templates in a separate repo so the URL is shorter. The template github repo gets mounted on the pod

extraVolumes: - name: custom-templates gitRepo: repository: " https://gitlab.com/slejdops/jhub-template.git" extraVolumeMounts: - mountPath: /usr/local/share/jupyter/hub/static/custom name: custom-templates subPath: "jhub-template/static/images"

and shorter URLs make the config files more readable

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/malariagen/jupyterhub/issues/17#issuecomment-401258800, or mute the thread https://github.com/notifications/unsubscribe-auth/AAq8QtwzyF5RupXFPqoC7xT2aJCySKL4ks5uBcZ1gaJpZM4UemuA .

-- If I do not respond to an email within a few days, please feel free to resend your email and/or contact me by other means.

Alistair Miles Head of Epidemiological Informatics Centre for Genomics and Global Health Big Data Institute Li Ka Shing Centre for Health Information and Discovery Old Road Campus Headington Oxford OX3 7LF United Kingdom Phone: +44 (0)1865 743596 or +44 (0)7866 541624 Email: alimanfoo@googlemail.com Web: http://a http://purl.org/net/alimanlimanfoo.github.io/ Twitter: @alimanfoo https://twitter.com/alimanfoo

slejdops commented 6 years ago

Added jhub-template to the jupyterhub repo

alimanfoo commented 6 years ago

Cool, thanks.