search

malariagen / malariagen-data-python

Analyse MalariaGEN data from Python
https://malariagen.github.io/malariagen-data-python/latest/
MIT License
13 stars 23 forks source link

KeyError: 'Stamen' #443

Closed alimanfoo closed 10 months ago

alimanfoo commented 10 months ago

As of release 2023.10.1 xyzservices has removed stamen tiles.

This causes KeyError: 'Stamen' when trying to import malariagen_data.

Temporary workaround:

pip install malariagen_data "xyzservices < 2023.10.1"
alimanfoo commented 10 months ago

Hi @leehart, any chance you could find a fix for this and make a micro release?

leehart commented 10 months ago

Hi @leehart, any chance you could find a fix for this and make a micro release?

Hi @alimanfoo . Sure, I'll do it first thing tomorrow.

alimanfoo commented 10 months ago

Awesome, thanks @leehart. Sorry forgot you were away today.

leehart commented 10 months ago

I had assumed from GeoPandas' statement Use Stamen styles of Stadia provider instead that these tiles would be available via Stadia instead, e.g.

    "terrain": ipyleaflet.basemaps.Stadia.StamenTerrain,
    "watercolor": ipyleaflet.basemaps.Stadia.StamenWatercolor,

but judging from Stamen's FAQs and this test, it looks like we might have to drop our support for watercolor and terrain maps from our map_params.py, sadly

Screenshot 2023-11-09 at 11 58 14 Screenshot 2023-11-09 at 12 06 49
leehart commented 10 months ago

From https://stadiamaps.com/stamen/

I thought Stamen Map Tiles were free? For many years, Stamen offered a completely free map tile service. Unfortunately, mapping services are expensive to maintain, and it wasn’t possible to continue supporting an entirely free service. We partnered with Stamen to continue offering these iconic styles as part of the Stadia Maps’ platform.

leehart commented 10 months ago

A new patch release has now been made (v7.14.1), but we probably want to guard against this fragility, somehow.