malariagen / malariagen-data-python

Analyse MalariaGEN data from Python
https://malariagen.github.io/malariagen-data-python/latest/
MIT License
13 stars 24 forks source link

Remove Stamen basemaps #445

Closed leehart closed 11 months ago

leehart commented 11 months ago

Re: issue #443

review-notebook-app[bot] commented 11 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

codecov[bot] commented 11 months ago

Codecov Report

Merging #445 (63a837b) into master (c637e39) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #445   +/-   ##
=======================================
  Coverage   97.50%   97.50%           
=======================================
  Files          26       26           
  Lines        2086     2086           
=======================================
  Hits         2034     2034           
  Misses         52       52           
Files Coverage Δ
malariagen_data/anoph/map_params.py 100.00% <ø> (ø)
ahernank commented 11 months ago

There might be other "terrain" sources if we wanted to regain this one in the future (e.g. https://github.com/geopandas/xyzservices/blob/5e9798aba5deafade06d11be573f5b1c1e993415/provider_sources/leaflet-providers-parsed.json#L674) but looking through all of those and deciding which one is the closest to the Stamen one seems well-outside of this fix..

leehart commented 11 months ago

Thanks @ahernank . Yes, there might be some other notebooks somewhere using these particular base maps tile sets, which will turn yucky due to Stamen withdrawing their free service, which is also affecting other middleware, e.g.: https://ipyleaflet.readthedocs.io/en/latest/map_and_basemaps/basemaps.html

...but the urgent problem is that it's preventing this package from being imported. We should probably look at avoiding this vulnerability, e.g. in case Esri also decide to withdraw their free service. I will merge and make a patch release shortly to re-enable package import.