Closed alimanfoo closed 7 months ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
Attention: 7 lines
in your changes are missing coverage. Please review.
Comparison is base (
7995a0f
) 98.49% compared to head (9967d13
) 98.59%. Report is 1 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
malariagen_data/anoph/snp_frq.py | 98.42% | 7 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
N.b. G123 is still relatively slow as most of the time is in retrieval of genotype data, but this does still make a difference.
Here we speed up G123 and H12 computations by using a faster approach to hashing.
Also a very minor broadening of the API
chunks
parameter, to allow exploration of whether different approaches to reading chunks of zarr data improves performance, although that actually doesn't seem to offer any performance benefits after all.