Add the correct nomenclature for genes in anopheles.py to enable CNVs for Af

malariagen / malariagen-data-python

Analyse MalariaGEN data from Python

https://malariagen.github.io/malariagen-data-python/latest/

MIT License

13 stars 23 forks source link

Add the correct nomenclature for genes in anopheles.py to enable CNVs for Af #500

Closed jonbrenas closed 7 months ago

jonbrenas commented 7 months ago

Will resolve #499.

I don't know yet if there are other instances where this problem occurs. I will add a test_gene_cnv for Af mirroring the one for Ag.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c560a96) 98.71% compared to head (5c8e544) 98.71%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #500 +/- ## ======================================= Coverage 98.71% 98.71% ======================================= Files 33 33 Lines 3277 3278 +1 ======================================= + Hits 3235 3236 +1 Misses 42 42 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

alimanfoo commented 7 months ago

Thanks @jonbrenas. I did a search through the code base and think this the only place where this occurs, so I think you can say that this PR will resolve #499.

review-notebook-app[bot] commented 7 months ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

jonbrenas commented 7 months ago

Thanks @alimanfoo , hopefully, I made the change.

jonbrenas commented 7 months ago

@alimanfoo , I think it is ready for review.