malariagen / malariagen-data-python

Analyse MalariaGEN data from Python
https://malariagen.github.io/malariagen-data-python/latest/
MIT License
13 stars 23 forks source link

Anopheles pca() should use default site mask #545

Closed alimanfoo closed 1 month ago

alimanfoo commented 1 month ago

Previously I recall that the Anopheles pca() function used the default site mask if the site_mask parameter was not given.

However, now looking at the code it seems that no site mask will be used if the site_mask parameter is not given, because the default value of the site_mask parameter is None. It probably should be "default" instead which is the general way to say "use a site mask please, whichever is the default for this data resource".