search

malariagen / malariagen-data-python

Analyse MalariaGEN data from Python
https://malariagen.github.io/malariagen-data-python/latest/
MIT License
13 stars 23 forks source link

Raise ValueError for missing CNV DRCs #576

Closed leehart closed 1 month ago

leehart commented 1 month ago

Re: issue #551

alimanfoo commented 1 month ago

Hi @leehart, maybe it would be better to handle this the same way as for HMM CNV data in #575? This will be more consistent internally, and in the extreme case where funestus never has an DRC data, it will still raise an error (if you add in the additional check I suggested here).

leehart commented 1 month ago

@alimanfoo Agreed. At one time it seemed that returning None would be consistent, and then raising ValueError like this would be consistent, but now it looks like everything is falling into line, along the same one true track, moving in the right direction! 👍

leehart commented 1 month ago

Plan to handle this the same way as for HMM data in #575 and haplotypes().