Open leehart opened 1 week ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
Looking good...
Hi @leehart, couple of comments...
One very small request, would it be possible to add just a little more vertical padding around the text labels? Particularly the negative strand gene labels are touching the gene rectangles, would be good to have a little padding.
The other request is that ultimately this will be needed as part of functions like plot_h12_gwss()
where there is a genes track plotted below some other data track. So basically, could you add a gene_labels
parameter to all functions like this, i.e., where plot_genes()
is called internally?
@alimanfoo How does this padding look to you?
Ideally I'd like a more robust mechanism for accommodating these labels, because this is currently tailored to the default height of the plot, i.e. 120, so specifying a different height, e.g. height=240
, results in a skewed layout, e.g.
Re: issue #407