search

malariagen / mgenv

Repository with installation scripts and environment definitions for conda and texlive, for standardising environments across the MalariaGEN resource centre team.
MIT License
1 stars 5 forks source link

Upgrades 2024-06-07 #139

Closed leehart closed 5 months ago

leehart commented 5 months ago

Resolves #138

alimanfoo commented 5 months ago

Thanks @leehart. Can we also resolve #137, #136 and #130 while we're doing some upgrades?

leehart commented 5 months ago

Can no longer (since v4) upload artifacts from separate runs into the same .zip artifact
Ref: issue https://github.com/actions/upload-artifact/issues/478

leehart commented 5 months ago

Cannot disable packaging artifact as a .zip, e.g. with compression-level: 0 Ref: issue https://github.com/actions/upload-artifact/issues/367

leehart commented 5 months ago

Hi @alimanfoo . In order to resolve deprecation warnings about GitHub actions checkout and upload-artifact, I attempted to upgrade them both to v4. However, v4 of upload-artifact does not handle multiple uploads (the pinned YAML files) as cleanly as v2 (or v3), as described in issues linked above. It appears that each artifact requires a separate .zip, which is a bit awkward. I have demonstrated a way to merge the separate artifacts into a single zip, as a subsequent step here, but the other zips remain, which is also not ideal.

In addition, this has lead to the renaming of the pinned files, at least for convenience, and I'm not sure if other processes are dependent on the pre-existing file names? I expect it should be possible to preserve the original names, somehow.

I'm starting to think the fallout from upgrading the GitHub actions might not have been worth the benefit of resolving a few deprecation warnings, although I suppose they would need addressing eventually. Any thoughts?