alimanfoo
commented
5 years ago Yes for cases like this I think it's ok to leave the package unpinned in requirements-conda.txt. You then just need to do a manual check in the generated pinned environment files that the version is what you expect (which I did when I reviewed the PR).
Another approach is to pin to a minimum version in requirements-conda.txt, e.g., add:
conda-forge::fsspec>=0.6.0
...which will ensure you get the required minimum version in the pinned environment. In general it's probably slightly better to express this minimum requirement in requirements-conda.txt as it's a bit more explicit and ensures you can't regress back to an earlier version if some version incompatibility arises with another package and the solver decides to try and downgrade fsspec. But I think either way is fine in this case.
On Thu, 14 Nov 2019 at 16:18, Lee notifications@github.com wrote:
Note that this upgrade does not need to be achieved via requirements-conda.txt, i.e.:
conda-forge::fsspec=0.6.0
I gather we want to avoid pinning versions.
For instance, fsspec wasn't pinned last time and got set to 0.5.2 in the pinned files.
So the version (along with others) should get bumped automatically via the Travis CI rebuild.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/malariagen/binder/issues/66?email_source=notifications&email_token=AAFLYQXQFZE3FRHK5UR5KITQTV24LA5CNFSM4JNN6YS2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEECMSNA#issuecomment-553961780, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFLYQWENA24IP27VJ3YEPDQTV24LANCNFSM4JNN6YSQ .
--
Alistair Miles Head of Epidemiological Informatics Centre for Genomics and Global Health Big Data Institute Li Ka Shing Centre for Health Information and Discovery University of Oxford Old Road Campus Headington Oxford OX3 7LF United Kingdom Phone: +44 (0)1865 743596 or +44 (0)7866 541624 Email: alimanfoo@googlemail.com Web: http://a http://purl.org/net/alimanlimanfoo.github.io/ Twitter: @alimanfoo https://twitter.com/alimanfoo
Please feel free to resend your email and/or contact me by other means if you need an urgent reply.
leehart
Note that this upgrade does not need to be achieved via
requirements-conda.txt, i.e.:I gather we want to avoid pinning versions.
For instance, fsspec wasn't pinned last time and got set to 0.5.2 in the pinned files.
So the version (along with others) should get bumped automatically via the Travis CI rebuild.