malariagen / mgenv

Repository with installation scripts and environment definitions for conda and texlive, for standardising environments across the MalariaGEN resource centre team.
MIT License
1 stars 5 forks source link

add umap-learn to requirements-conda.txt #69

Closed slejdops closed 5 years ago

slejdops commented 5 years ago

Resolves #62.

alimanfoo commented 5 years ago

(Thanks @slejdops, looks like CI passed so now you could recreate the environment-pinned-* files from the CI logs.) Done already :-)

alimanfoo commented 5 years ago

@slejdops if CI passes please feel free to merge.

alimanfoo commented 5 years ago

Hi @slejdops, sorry should have explained, it's good to wait until CI passes after you re-add the environment-pinned-... files. When the pinned files are present, CI will use them to try and create an environment. So this final CI check shows that the pinned files work.

alimanfoo commented 5 years ago

This is the final CI build that will use the new pinned files, it's passed so we're all good :-)

alimanfoo commented 5 years ago

Thanks @slejdops for doing this. I've tagged the new environment as v2.4.0 but let's hold off upgrading datalab for the moment, there's been a lot of churn recently, we don't need this urgently.