search

malawski / cloudworkflowsimulator

Other
24 stars 20 forks source link

DAG parser can create task with nulled input jobs #20

Open Mequrel opened 11 years ago

Mequrel commented 11 years ago

task.getInputFiles() or task.getOutputFiles should never return null. It's better to return empty list.

Please remove also null sanity checks from DAGDynamicScheduler

bryk commented 11 years ago

Side comment: there are plenty of sanity checks everywhere. I'd be better if we had unit test instead :) But the code is already written, so we have somehow to live with this.

I agree that incremental removal of sanity checks and additions of unit tests is good.