search

malaysiamidwestgames / sambal

Web platform for Midwest Games
6 stars 0 forks source link

Sports payment = false on dashboard #3

Open vanblaze opened 9 years ago

vanblaze commented 9 years ago

So I don't really know whether this is a bug or we should remove this function all together.

So right now, if you don't pay for Sports Registration, a 'false' is showed. As seen on the screenshot attached below. screen shot 2015-04-30 at 3 39 30 pm

As you can see, in the Payments tab, sports registration is false.

There are two questions we have here.

  1. Why is it returning false? According AngularJs, it shouldn't return false, but it should return a string. Are we doing something wrong from the API side?
  2. Do we need that? Given that each team_captain will pay for their team, do we need to actually specify to them whether they have or have not paid for each sports because we already did that for the green button, where the team_captain will never be allowed to register for another sports if he has not paid for another sport that he has registered. So we can probably still include it on the dashboard, but we probably need to be more specific about what has not been paid and they should paid it now.

Requirements You will need to debug AngularJs, specifically why is it false and why is it not printing the string we have. You will need to think about whether we actually need that info on the dashboard. If so, how do we actually display it in a proper manner.

everaldo23 commented 9 years ago

I already fixed this but I just didn't push it.

vanblaze commented 9 years ago

Oh nice! Ok. When you push it, we will close this issue.

Thanks!

vanblaze commented 9 years ago

I think we should take out the Payment from the dashboard, and put it a part of User Settings or more specifically Payment History. It's going to clutter the dashboard soon. I was thinking of making use of the space for like an announcement + social feed system.