malcolmang / pe

0 stars 0 forks source link

`Edit-Expense` says editing is done successfully when there is no error #4

Open malcolmang opened 2 years ago

malcolmang commented 2 years ago

image.png

Everything after -e EXPENSE-INDEX is deemed optional, so users can just type Edit-Expense -e EXPENSE-INDEX without any further arguments. This doesn't actually edit anything, but produces a success message saying the expense was edited successfully.

It may be better to throw an error or tell the user that no editing took place.

nus-pe-script commented 2 years ago

Team's Response

Greetings malcolmang,

Thank you for your bug report. After careful evaluation of your bug report, the development team is accepting your bug report.

Regards, xzynos

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Edit Expense returns succesful edit even when nothing's being edited

Screenshot 2022-11-11 at 4.45.34 PM.png

This edit expense feature is not complete - as for instance, when I am not passing any arguments to actually edit the current expense, it still returns it as successful edit expense, instead of an error message like "you have not passed in any arguments to edit the current expense!".


[original: nus-cs2113-AY2223S1/pe-interim#815] [original labels: type.FeatureFlaw severity.Low]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Greetings karthikstar,

Thank you for your bug report. After careful evaluation of your bug report, the development team is accepting your bug report.

Regards, xzynos

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


:question: Issue type

Team chose [type.FeatureFlaw] Originally [type.FunctionalityBug]

Reason for disagreement: [replace this with your explanation]


:question: Issue severity

Team chose [severity.Low] Originally [severity.VeryLow]

Reason for disagreement: [replace this with your explanation]