search

malcolmw / pykonal

Travel-time calculator based on the fast-marching method solution to the Eikonal equation.
https://malcolmw.github.io/pykonal-docs/
GNU General Public License v3.0
154 stars 55 forks source link

Publish to PyPI #18

Closed lukaszmoroz closed 1 year ago

lukaszmoroz commented 3 years ago

Hey, could you put the package on PyPI as well? Not everyone can use Conda, and I believe that nowadays PyPI supports publishing cython binary wheels.

malcolmw commented 3 years ago

Hi, @lukaszmoroz, Sure I can add to PyPI, but you don't need conda to install pykonal. Just clone the respository and run pip install . from the top level directory.

lukaszmoroz commented 3 years ago

I know that, but still, I think putting it on PyPI would help with discoverability (I was trying to use scikit-fmm initially with little success and only later, after a few more google searches I came across this repo).

Also, I'm using Poetry to manage my dependencies and installing your package from a git repo (or alternatively a local folder):

[tool.poetry.dependencies]
# ...
pykonal = { git = "https://github.com/malcolmw/pykonal.git", tag = "0.3.2b1" }

I experienced an issue: your setup.py imports cython and numpy but you don't specify them as build dependencies (in addition to install dependencies), so the package can't be built if you don't happen to have them already installed. Therefore you need a pyproject.toml that specifies those (I can make a PR with it if you want).

With this change I'm able to install your package directly from github, but it's not the most convenient way (e.g. it doesn't allow specifying version ranges).

malcolmw commented 3 years ago

I see. I haven't seen a workflow like yours before, so a PR would be great! Thanks for the feedback!

-Malcolm

malcolmw commented 1 year ago

Closing this as complete (finally). Thanks @jobh!