search

malcolmw / pykonal

Travel-time calculator based on the fast-marching method solution to the Eikonal equation.
https://malcolmw.github.io/pykonal-docs/
GNU General Public License v3.0
147 stars 54 forks source link

numpy bool issue #28

Closed SquirrelKnight closed 1 year ago

SquirrelKnight commented 1 year ago

In newer versions of numpy, np.bool is removed and bool is accepted. I would recommend either adding a specific version of numpy to the installation instructions, or changing constants.pyx so that DTYPE_BOOL = bool

The latest versions of numpy also accept float64, uint32, etc. without needing to prepend np.

malcolmw commented 1 year ago

Sorry for the delay on this. I changed DTYPE_BOOL=np.bool in constants.pyx to DTYPE_BOOL=np.bool_, and it should work with the latest version of NumPy now. This update is included in the v0.2.3b4: https://github.com/malcolmw/pykonal/releases/tag/0.2.3b4.

Closing this issue now, but please feel free to re-open if the problem persists or any downstream bugs emerge.