search

maldworth / aldsoft.acord

.NET Helper Library for Serializing and Deserializing ACORD LA XML
MIT License
15 stars 6 forks source link

TXLife2 xsd question #3

Closed stephenpatten closed 6 years ago

stephenpatten commented 6 years ago

Hello,

First off, thank you for an awesome library.

I have access to the Acord xsds, and have a copy of xsd2code++, but there are 4 of them

TXLife2.40.00.xsd TXLife2.40.00clean.xsd TXLife2.40.00enum.xsd TXLife2.40.00fulldoc.xsd

Which one do you use to gen the TX? I'm also wanting to gen without IPropertyNotify and may split the classes.

Any help would be appreciated. I 'could' PR it too if you wanted.

Thank you, Stephen

maldworth commented 6 years ago

I'm doing some updates in a branch (.net core support), plus it will have a powershell you can use which has the params to pass into xsd2code++ for generation. Also, I agree, the IPropertyNotify stuff is unnecessary and will be removed in the generation.

If you wait a few more days I should have the branch for you to use. And then a PR back in with the 2.40 generated Cs file would be great!

stephenpatten commented 6 years ago

Sounds like a plan.

On Thu, Oct 4, 2018 at 5:32 PM maldworth notifications@github.com wrote:

I'm doing some updates in a branch (.net core support), plus it will have a powershell you can use which has the params to pass into xsd2code++ for generation. Also, I agree, the IPropertyNotify stuff is unnecessary and will be removed in the generation.

If you wait a few more days I should have the branch for you to use. And then a PR back in with the 2.40 generated Cs file would be great!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/maldworth/aldsoft.acord/issues/3#issuecomment-427211092, or mute the thread https://github.com/notifications/unsubscribe-auth/AAVpqLI7QwpVgmUZxeVZU5I4oynitCe4ks5uhqiBgaJpZM4XDCE9 .

maldworth commented 6 years ago

I'll need some more time. Spent some time tinkering around and am having trouble finding the original settings that were used to generate.

stephenpatten commented 6 years ago

They're in the header of the TXLife file, right?

On Mon, Oct 8, 2018 at 4:29 PM maldworth notifications@github.com wrote:

I'll need some more time. Spent some time tinkering around and am having trouble finding the original settings that were used to generate.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/maldworth/aldsoft.acord/issues/3#issuecomment-428011115, or mute the thread https://github.com/notifications/unsubscribe-auth/AAVpqMYiX6G8dIlPyyhx9NTg8btr3a3Fks5ui9_bgaJpZM4XDCE9 .

maldworth commented 6 years ago

Yeah I have the params the same. The problem is it seems to be generating differently. The only variable is I think updates to VS and the .net framework have updated the xsd.exe running. Anyways it's generating, but now the unit tests are failing. So I'm going to chip away at that.

maldworth commented 6 years ago

Good news, I have a branch you can use. it's called feat/cakebuild Has a /generate folder. All you need to do it put the schema in a folder under the generate folder (./generate/schemas), and run the powershell.. should handle everything from there, and copy it to the csproj folder as well.

I still have some cakebuild and appveyor items to cleanup in there. I should get to that this weekend.

stephenpatten commented 6 years ago

I did a quick deep dive last night with 2.38 but then was really confused when I found a 2.40 folder, I chalked it up to being tired :) but in fact you had added an empty 22.40 project folder. I have the 2.38 and 2.40 xsds atm and will try to back fill between 2.35 and 2.40 once our rep gives me the missing ones. For the time being I'll try 2.38 to stay out of your way.

-Stephen

On Wed, Oct 10, 2018 at 8:10 PM maldworth notifications@github.com wrote:

Good news, I have a branch you can use. it's called feat/cakebuild Has a /generate folder. All you need to do it put the schema in a folder under the generate folder (./generate/schemas), and run the powershell.. should handle everything from there, and copy it to the csproj folder as well.

I still have some cakebuild and appveyor items to cleanup in there. I should get to that this weekend.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/maldworth/aldsoft.acord/issues/3#issuecomment-428805032, or mute the thread https://github.com/notifications/unsubscribe-auth/AAVpqLSV4BE8wKfDoT4bGci-3KOt98G_ks5ujraxgaJpZM4XDCE9 .

maldworth commented 6 years ago

I added the 2.40 folder for you, just to get it ready :). But please feel free to add folders/csproj for each version you have.

stephenpatten commented 6 years ago

I just ran 38 and 40 in one batch, nice script btw.

On Sat, Oct 13, 2018 at 9:55 AM maldworth notifications@github.com wrote:

I added the 2.40 folder for you, just to get it ready :). But please feel free to add folders/csproj for each version you have.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/maldworth/aldsoft.acord/issues/3#issuecomment-429557419, or mute the thread https://github.com/notifications/unsubscribe-auth/AAVpqGRmu9q8R72R8B2Ic2FCUjoHxwlVks5ukhsQgaJpZM4XDCE9 .

stephenpatten commented 6 years ago

Ah crap!

I've never participated on GitHub, so I may have done my branch wrong from the beginning, sorry. I cloned feat/cake and made the changes in my local branch, can you add stephenpatten as a contibutor? v 2.38 / v 2.40 are done, less the tests.

On Sat, Oct 13, 2018 at 10:12 AM Stephen Patten stephenpatten@gmail.com wrote:

I just ran 38 and 40 in one batch, nice script btw.

On Sat, Oct 13, 2018 at 9:55 AM maldworth notifications@github.com wrote:

I added the 2.40 folder for you, just to get it ready :). But please feel free to add folders/csproj for each version you have.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/maldworth/aldsoft.acord/issues/3#issuecomment-429557419, or mute the thread https://github.com/notifications/unsubscribe-auth/AAVpqGRmu9q8R72R8B2Ic2FCUjoHxwlVks5ukhsQgaJpZM4XDCE9 .

maldworth commented 6 years ago

I see you got it. Typically how you do it is you create a fork, then make your changes. Then submit a PR from your repo into here. If you ever want to contribute more, and you want my changes (for example from master branch). You would have to set up an "upstream remote" to my repo. git remote add upstream.... Then any updates I put into master here, you could pull them into your fork with git pull upstream master for example.

Thanks for PR #4 Added the tests and everything is passing. So the last bit is getting the packages into nuget.

maldworth commented 6 years ago

Okay, 0.3.0 is released. thanks for all your help.

stephenpatten commented 6 years ago

The pleasure is mine.

I love reading good code and this was an opportunity to explore a few new concepts, like the command-line args being passed to xsd2code in power-shell, cake builds.

Next, I'm going to explore serializing objects graphs when the TXLife is single file, or broken down into constituent classes. Maybe we got rid of the pause when loading due to INotifyProperyChange.

I also see you work on MassTransit. I have an opportunity to rewrite a home grown "notification engine" that polls a database queue... with something more event driven. MT also supports both RabbitMQ and SQS transports, which is a plus since we have a roadmap to the cloud in the next 4 years.

On Sun, Oct 14, 2018 at 12:32 PM maldworth notifications@github.com wrote:

Okay, 0.3.0 is released. thanks for all your help.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/maldworth/aldsoft.acord/issues/3#issuecomment-429655128, or mute the thread https://github.com/notifications/unsubscribe-auth/AAVpqLIIHLyWWvmcesiohrPjFhrrgU7Nks5uk5E1gaJpZM4XDCE9 .

maldworth commented 6 years ago

Object graphs, that sounds fun. Thank you, and MassTransit is a really great abstraction to help get introduced into the world of Service Buses. Whenever I hear people are interfacing directly with RabbitMQ, or AzureSB, or SQS, I always try to steer them towards MassTransit.

When you start tackling that re-write, if you ever have any questions about MassTransit head over to the Gitter Channel. There's always a helpful community member there (sometimes myself).

Cheers!